Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT -778 support password reset by otp code and verification_method field in conn. #1113

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

ramya18101
Copy link
Contributor

🔧 Changes

Supporting an new email template - reset_email_by_code used for change password (code) as part of PRD

API changes for connection to support verification_method for connections using Email as Identifier

📚 References

https://oktawiki.atlassian.net/wiki/spaces/TES/pages/2947983224/PRD+Email+OTP+Verification+as+part+of+Signup+Password+Reset
https://oktawiki.atlassian.net/wiki/spaces/USER/pages/3091797031/API+changes+for+Email+OTP+PWR+Verification

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (6387564) to head (8539d42).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   89.29%   89.21%   -0.09%     
==========================================
  Files         130      130              
  Lines       18027    18057      +30     
==========================================
+ Hits        16097    16109      +12     
- Misses       1363     1379      +16     
- Partials      567      569       +2     
Files with missing lines Coverage Δ
internal/auth0/connection/expand.go 93.29% <100.00%> (+<0.01%) ⬆️
internal/auth0/connection/flatten.go 80.63% <100.00%> (+0.02%) ⬆️
internal/auth0/email/resource_template.go 89.51% <100.00%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

@ramya18101 ramya18101 marked this pull request as ready for review January 9, 2025 08:58
@ramya18101 ramya18101 requested a review from a team as a code owner January 9, 2025 08:58
@ramya18101 ramya18101 merged commit 469673d into main Jan 16, 2025
5 checks passed
@ramya18101 ramya18101 deleted the DXCDT-778-support-password-reset-by-otp-code branch January 16, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants